Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create github workflow for the subtopology autocoder #2794

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from

Conversation

mosa11aei
Copy link
Contributor

Related Issue(s) n
Has Unit Tests (y/n) n/a
Documentation Included (y/n) n/a

Change Description

This change implements a Github CI workflow for testing the Subtopology Autocoder. This will ensure that changes made to F Prime do not break the tool itself.

.github/workflows/ext-build-subtopology-ac.yml Outdated Show resolved Hide resolved
.github/workflows/ext-build-subtopology-ac.yml Outdated Show resolved Hide resolved
@mosa11aei
Copy link
Contributor Author

mosa11aei commented Jul 8, 2024

@thomas-bc can you run CI again? It should work now.

The rest of the spelling mistakes will be fixed when the docs PR (#2743) is merged in.

bocchino and others added 2 commits July 18, 2024 11:02
* Update fpp version

Revise framework code to match

* Update fpp version

* Update fpp version

* Update fpp version
@mosa11aei mosa11aei requested a review from thomas-bc July 18, 2024 23:55
repository: nasa/fpp
path: ./fpp
ref: main
- name: "[fpp] Install sbt"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of non native fpp install

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosa11aei if it were me I would get rid of all the installs, since all those tools come pre-installed on the GitHub runners. This may prevent breakages in the future. Your call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This specifically relates to something @LeStarch and I talked about today. See #2816 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants