Use a single source of truth for InFlight calculation #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndn-consumer-window and ndn-consumer-pcon use a simple count for updating the number of InFlight packets. This works fines as long as no packet arrives after its timeout has fired. In this case `m_inFlight` is decreased twice. Ultimately the counter (wrongly) reaches 0 and prevents proper working of the window algorithm. This fix does away with the manual calculation of the counter and replaces it with the size of the `m_seqTimeouts` set. Signed-off-by: Miguel Rodríguez Pérez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ndn-consumer-window and ndn-consumer-pcon use a simple count for
updating the number of InFlight packets. This works fines as long as no
packet arrives after its timeout has fired. In this case
m_inFlightisdecreased twice. Ultimately the counter (wrongly) reaches 0 and prevents
proper working of the window algorithm.
This fix does away with the manual calculation of the counter and replaces
it with the size of the
m_seqTimeoutsset.Signed-off-by: Miguel Rodríguez Pérez [email protected]