Update bootstrapDialog for Bootstrap version 4.0.

[avan06]

A modified version is downward compatible,

[ellisio]

As of the latest v4 Alpha release this no longer works. You get this error when compiling via Grunt:

Error: Cannot find module 'bootstrap' from '/Users/andrew/Developer/Kicka/Seminar/node_modules/bootstrap3-dialog/dist/js

This will be fixed in the v4-alpha-3.1 patch.

[EugenMayer]

Just to mention, also working on this, using @avan06 code https://github.com/EugenMayer/bootstrap-dialog and some additions like bower dependency fixes. I am the the middle of testing it against bootstrap-4dev and could join this to see how far we get this

[EugenMayer]

At least this EugenMayer#4 and that EugenMayer#1 would be needed to get some sort of working copy.

[EugenMayer]

created a jsfiddle with bootstrap 4 http://jsfiddle.net/o5k0eaws/217/

[EugenMayer]

i updated the jsfiddle to outline one issue:
Bootstrap 4: http://jsfiddle.net/o5k0eaws/219/
Bootstrap 3: http://jsfiddle.net/o5k0eaws/220/

In bootstrap3, the modal-backdrop handling works, so the first dialog is overlayed by the backdrop, in bootstrap it is not. The reason is, that the modal-backdrops do not get a z-index at all.

Using bootstrap4 with the classic API though, does work : http://jsfiddle.net/o5k0eaws/222/
So bootstrap 4 in general works with the classic API, but when using setModal it does not yet work

[nakupanda]

Thanks for this try for bootstrap 4, it's been long since last time folks talking about this.

I'm haven't read through bootstrap yet, I will arrange my time on it and them see how to create bootstrap 4-dialog.

[EugenMayer]

Well the only issue i am for now encountering is the one outlined in http://jsfiddle.net/o5k0eaws/219/ .. with the special use of bootstrap-dialog .. the modal-backdrop handling fails. Could you point me in a direction looking for thaT?

[digixweb]

I also get this error: "bootstrap3-dialog": "^1.35.3",

Browserify Failed!: Cannot find module 'bootstrap' from '/home/vagrant/dev/mbm/node_modules/bootstrap3-dialog/dist/js'

[mediatvguy]

Greetings from Florida :)

Any news on bootstrapDialog for V. 4 ?

[EugenMayer]

As much news as from bootstrap 4 itself, none

[mediatvguy]

:(

[nakupanda]

Sorry, none..

[bindrid]

Note: bootstrap 4 beta is now out. In there documentation, they do not support stacked modals as they consider it a bad user experience. https://getbootstrap.com/docs/4.0/components/modal/

[bindrid]

I got Avan06 's version working. I had to add "col" class to the three sections, header, body and footer.
I also put a float right on the footer button container.

    createHeaderContent: function () {
        var $container = $('<div></div>');
        $container.addClass(this.getNamespace('header') + " col"); 

[Oviglo]

+1

[nakupanda]

@bindrid in bs3 it's also suggested not to use stacked modals.

[alpertandogan]

in css file i made this modification for bootstrap 4

.bootstrap-dialog .bootstrap-dialog-footer-buttons .btn{
margin-right: 5px;
}
.bootstrap-dialog .bootstrap-dialog-footer-buttons .btn:last-child{
margin-right: 0;
}

[tmaly1980]

FYI, bootstrap-v4.0.0-beta.2 is out. @nakupanda Why is this sitting around for months? This library is essential IMO for modals so I don't have to actually code the HTML manually.

[EugenMayer]

@tmaly1980 don't hold yourself back, go forward and do the essential work?

[tmaly1980]

@EugenMayer It looks like it's been done already, by @avan06 . Merge request has been sitting around since August.

Also looks like you did some work on this in your own cloned repo. How far did you get?

[l0ft13]

+1

[Oviglo]

Thank you !

[Jako]

It would be nice, if the work of @avan06 could be included here.

[leankuroneko]

Indeed! I had to remove the plugin because Yii updated Bootstrap and the functionality loss is noticeable :(

[TCardinal]

it would be good to get this merged now. holding things up.

[leankuroneko]

I tested this fix. It solves compatibility and although some css issues appear, it makes the plugin usable again.

[Oviglo]

Do you try with the last version of Bootstrap (4.1) ? I have this error:

Uncaught TypeError: Cannot set property 'paddingRight' of undefined

"element" var seem to be a jQuery object but it call native 'css' attribute

EDIT: Ok I think it's normal, just add 4.1 version :)

[rmihaig]

Hello,
I managed to make this work with 4.1 by changing this line
} else if (/4.0.\d+/.test($.fn.modal.Constructor.VERSION)) { //FIXME for BootstrapV4
with this one
} else if (/4.\d+/.test($.fn.modal.Constructor.VERSION)) { //FIXME for BootstrapV4

[GedMarc]

+1 !
:)

[alcidesfmelof]

Ho can I download a version that works with bootstrap 4.1?

[GedMarc]

I took all the changes and applied them, if you just want quick js files can grab these https://github.com/GedMarc/Bootstrap-Dialog4/tree/master/jar-resources/META-INF/resources/bower_components/bootstrap4-dialog/dist/js

[JavaTMP]

We created Bootstrap modal Wrapper plugin for bootstrap 4.1 that does not depends on any external CSS other than standard bootstrap css file which supports dynamic and stack modal creations in this repository https://github.com/JavaTMP/bootstrap-modal-wrapper

[GedMarc]

There are more places that require updates 👍
BootstrapDialogModal.METHODS_TO_OVERRIDE['v4.1'] = $.extend({}, BootstrapDialogModal.METHODS_TO_OVERRIDE['v3.3']);

Add at line 148, maybe with the \d?

[GedMarc]

https://github.com/GedMarc/bootstrap4-dialog contains all the required changes + all BS4 updates for colour themes (LESS Change) + extra wide width (size:extrawide)
Supports 4.0 alpha 3 -> Current 4.1

This repo doesn't look to be maintained, the other repo's have partial updates

[nakupanda]

I'm that one who is a bit out of date.. which one is best to be merged? or nothing to be merged?

[firepol]

@GedMarc I tested your repo in my project, it works, but I had to install it like this:

yarn add https://github.com/GedMarc/bootstrap4-dialog

and in my node_modules it still shows in the folder bootstrap3-dialog and in the packages.json it still shows as bootstrap3-dialog.

I'd expect it to show as bootstrap4-dialog. Maybe can you update the version and make it installable via npm, since this repo doesn't look updated much, it makes sense to make your fork more visible and discoverable...

Or @nakupanda do you plan any updates on this? Bootstrap 4 is stable since ages now...

[GedMarc]

@nakupanda Up to you bud! You did the bulk of the work xD I can do a pull request for you, but the request to update the bower packages to reflect the compatibility makes sense,
I think I'll be updating my package info tho -

[GedMarc]

@firepol I put it up, the version matches the current bootstrap 4 that it is compatible for :
https://www.npmjs.com/package/bootstrap4-dialog

npm install bootstrap4-dialog
bower install bootstrap4-dialog-gedmarc