Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Context to EasyContext and View to EasyView for SwiftUI compatibility #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tcwalther
Copy link

SwiftUI introduces the structs View and Context. EasyPeasy's own structs of the same name conflict with this, which leads to errors in files where you include both SwiftUI and EasyPeasy.

This PR renames EasyPeasy's View and Context to EasyView and EasyContext. This fixes the incompatibility. I've decided not to rename file names, so Context.swift remains Context.swift, as that felt more in line with the other filenames.

@nakiostudio-bot
Copy link
Collaborator

Current coverage for EasyPeasy.framework is 96.21%

Files changed - -
Item+UIKit.swift 87.50%
Item.swift 93.88%
Attribute.swift 99.31%
Context.swift 100.00%

Powered by xcov

Generated by 🚫 Danger

@muukii
Copy link
Collaborator

muukii commented Jan 11, 2021

IMO:
EasyPeasy module has struct EasyPeasy symbol. that is the actual problem.
Because we can't specify which symbol we needed to use by writing module name.
If struct EasyPeasy has been renamed, this PR's motivation might change.

What do you think? @tcwalther @nakiostudio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants