New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Implement AI Assistant chat UI #9300
Conversation
… new chat variables.
* master: feat(Telegram Node): Disable page preview by default (#9267) fix(Jira Trigger Node): Update credentials UI (#9198) fix(LangChain Code Node): Fix execution of custom n8n tools called via LC code node (#9265) fix(editor): Prevent excess runs in manual execution with run data (#9259) fix(Baserow Node): Update logo (no-changelog) (#9261) fix(Customer.io Node): Update logo (no-changelog) (#9262) fix(LangChain Code Node): Fix resolution of scoped langchain modules (#9258) fix(core): Prevent node param resolution from failing telemetry graph generation (#9257) feat(Groq Chat Model Node): Add support for Groq chat models (#9250) ci: Update release-push-to-channel.yml (no-changelog) (#9254) refactor: Update Langchain dependencies (no-changelog) (#9252) refactor(editor): Rewrite TabBar to composition API (no-changelog) (#9231) refactor(core)!: Switch default Postgres user from `root` to `postgres` (#9248) fix(OpenAI Node): Allow to pass files ids as comma separated string in expressions (no-changelog) (#9240) refactor(Structured Output Parser Node): Sandbox JSON schema parsing (no-changelog) (#9239) feat(Ollama Chat Model Node): Add aditional Ollama config parameters & fix vision (#9215)
* master: feat(Redis Node): Add support for TLS (#9266) fix: Cast boolean values in filter parameter (#9260) 🚀 Release 1.40.0 (#9286) feat: Add Ask AI to HTTP Request Node (#8917) fix(Google BigQuery Node): Better error messages, transform timestamps (#9255) feat(Postgres Node): Add option IS NOT NULL and hide value input fields (#9241) feat(S3 Node): Add support for self signed SSL certificates (#9269) # Conflicts: # packages/editor-ui/src/stores/ai.store.ts
…ting some details according to the handoff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work as expected 👌 I left a few comments/suggestions. Also, how could we test this?
packages/editor-ui/src/components/AIAssistantChat/AIAssistantChat.vue
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/AIAssistantChat/AIAssistantChat.vue
Outdated
Show resolved
Hide resolved
3 flaky tests on run #4881 ↗︎
Details:
5-ndv.cy.ts • 2 flaky tests
24-ndv-paired-item.cy.ts • 1 flaky test
Review all test suite changes for PR #9300 ↗︎ |
* master: fix(core): Prevent occassional 429s on license init in multi-main setup (#9284) fix(Gmail Node): Remove duplicate options when creating drafts (#9299) refactor(core): Use logger for `packages/cli` messages (no-changelog) (#9302) fix(editor): Show MFA section to instance owner, even when external auth is enabled (#9301) fix(editor): Resolve `$vars` and `$secrets` in expressions in credentials fields (#9289) fix(n8n Form Trigger Node): Fix missing options when using respond to webhook (#9282) refactor(editor): Migrate `pushConnection` mixin to composable and remove collaboration store side effects (no-changelog) (#9249)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm just wondering, did you test the new changes with the Chat Trigger node?
@OlegIvaniv thanks! |
I did some testing on my local instance with your changes, and everything seems to be working as expected. Thanks! |
✅ All Cypress E2E specs passed |
Got released with |
Summary
This PR introduces initial version of the Generate next step AI Assistant. It will be used as an experiment at first but should become a full-fledged feature soon.
Review notes
Please take a look at this Linear comment before reviewing.
How to test
See here
Related tickets and issues
ADO-2190
Review / Merge checklist
(no-changelog)
otherwise. (conventions)