fix: console error in ActionsMode when searching for action and pressing enter. #9292
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
n8n-assistant
bot
added
community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When entering the node search right tab and searching for example "Google Analytics" and then searching through Google Analytics Actions options and entering some gibberish text and then hitting "Enter" Key an error appears where says
Cannot read key of undefined.This PR simply blocks the function from executing if no action is found the emit call will not get executed, I'm sure there might be couple places where we need to place this if check just to make sure. however I just found this for now.
Review / Merge checklist