Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add backend license checks for RBAC #9271

Merged
merged 4 commits into from May 6, 2024

Conversation

valya
Copy link
Contributor

@valya valya commented May 1, 2024

Summary

Add licensing checks for the backend. Frontend is still required.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 1, 2024
import { License } from '@/License';
import { UNLIMITED_LICENSE_QUOTA } from '@/constants';

export class TeamProjectOverQuotaError extends Error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering whether we should extend ApplicationError instead, so we can set it as warning and avoid this ending up in sentry wdyt?

Copy link

cypress bot commented May 6, 2024

9 failed and 1 flaky tests on run #4871 ↗︎

9 202 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 valya 🗃️ e2e/*
Project: n8n Commit: f455695925
Status: Failed Duration: 05:44 💡
Started: May 6, 2024 2:52 PM Ended: May 6, 2024 2:58 PM
Failed  17-sharing.cy.ts • 8 failed tests

View Output Video

Test Artifacts
Sharing > should create C1, W1, W2, share W1 with U3, as U2 Test Replay Screenshots Video
Sharing > should create C2, share C2 with U1 and U2, as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U2 Test Replay Screenshots Video
Sharing > should not have access to W2, as U3 Test Replay Screenshots Video
Sharing > should have access to W1, W2, as U1 Test Replay Screenshots Video
Sharing > should automatically test C2 when opened by U2 sharee Test Replay Screenshots Video
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video
Failed  39-projects.cy.ts • 1 failed test

View Output Video

Test Artifacts
Projects > should handle workflows and credentials Test Replay Screenshots Video
Failed  11-inline-expression-editor.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  18-user-management.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  9-expression-editor-modal.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 37 specs in Cypress Cloud.

Flakiness  cypress/e2e/19-execution.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Execution > should test manual workflow stop Test Replay Screenshots Video

Review all test suite changes for PR #9271 ↗︎

Copy link
Contributor

github-actions bot commented May 6, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

github-actions bot commented May 6, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@krynble krynble merged commit 3db25dd into feature/rbac May 6, 2024
24 of 28 checks passed
@krynble krynble deleted the pay-1549-license-changes branch May 6, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants