Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Invoice Ninja Node): Add more query params to getAll requests #9238

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

CodeShakingSheep
Copy link
Contributor

@CodeShakingSheep CodeShakingSheep commented Apr 29, 2024

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

This PR adds more query parameters to existing getAll requests:

Additionally, this PR fixes a small typo contactsValues instead of contacstValues.

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

None available. The background of this PR is that I needed some additional filtering (especially for getting my invoices) to make the requests faster (and not unnecessarily load all entities).

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@CodeShakingSheep CodeShakingSheep changed the title feat(InvoiceNinja Node): Add more query params to getAll requests feat(Invoice Ninja Node): Add more query params to getAll requests Apr 29, 2024
@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Apr 29, 2024
@Joffcom
Copy link
Member

Joffcom commented Apr 29, 2024

Hey @CodeShakingSheep,

The name typo you have fixed is annoyingly a breaking change, Are you able to revert that? This is something we will probably fix in a v2 of the node.

@CodeShakingSheep
Copy link
Contributor Author

Hey @CodeShakingSheep,

The name typo you have fixed is annoyingly a breaking change, Are you able to revert that? This is something we will probably fix in a v2 of the node.

Hey @Joffcom ,
Thanks for the hint. I wasn't assuming this would be a breaking change. I just pushed a commit 49f344c to revert the typo fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants