refactor: use two stage accept #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
this is so each step of the accept process is cancel-safe we might want to deprecate the combined fn.
rklaehn
force-pushed
the
two-stage-accept
branch
2 times, most recently
from
c4d76b8
to
6feb147
Compare
also get rid of accept_and_read_first
rklaehn
force-pushed
the
two-stage-accept
branch
from
6feb147
to
b3c37ff
Compare
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Jun 26, 2024
## Description fix(iroh): use two stage accept from quic-rpc to make the accept process cancel-safe Needs n0-computer/quic-rpc#87 ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. --------- Co-authored-by: dignifiedquire <[email protected]>
rklaehn
added a commit
to n0-computer/iroh-blobs
that referenced
this pull request
Oct 22, 2024
## Description fix(iroh): use two stage accept from quic-rpc to make the accept process cancel-safe Needs n0-computer/quic-rpc#87 ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. --------- Co-authored-by: dignifiedquire <[email protected]>
rklaehn
added a commit
to n0-computer/iroh-blobs
that referenced
this pull request
Oct 22, 2024
## Description fix(iroh): use two stage accept from quic-rpc to make the accept process cancel-safe Needs n0-computer/quic-rpc#87 ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. --------- Co-authored-by: dignifiedquire <[email protected]>
matheus23
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Nov 14, 2024
## Description fix(iroh): use two stage accept from quic-rpc to make the accept process cancel-safe Needs n0-computer/quic-rpc#87 ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. --------- Co-authored-by: dignifiedquire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is so each step of the accept process is cancel-safe
we might want to deprecate the combined fn.
Questions:
leave the combined one in? NO
should accept return a
Result<impl Future...>or aResult<Accepting>where Accepting has a fn that resolves to a future?returning a concrete type that implements Future itself is not possible without boxing, and I don't want to do this because we care about allocations for the mem path.
impl Future: works fine if you use it as is, but might be a pain if you want to pass it to a handler fn
concrete type: is slightly less verbose in direct use, but easier when passing to a handler fn