Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is so each step of the accept process is cancel-safe
we might want to deprecate the combined fn.
Questions:
leave the combined one in? NO
should accept return a
Result<impl Future...>
or aResult<Accepting>
where Accepting has a fn that resolves to a future?returning a concrete type that implements Future itself is not possible without boxing, and I don't want to do this because we care about allocations for the mem path.
impl Future: works fine if you use it as is, but might be a pain if you want to pass it to a handler fn
concrete type: is slightly less verbose in direct use, but easier when passing to a handler fn