Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

单引号错误 #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

单引号错误 #89

wants to merge 1 commit into from

Conversation

iluchen
Copy link

@iluchen iluchen commented Mar 13, 2019

当只使用gitalk的时候,这个地方的格式错误会导致gitalk加载失败。

当只使用gitalk的时候,这个地方的格式错误会导致gitalk加载失败。
@mzlogin
Copy link
Owner

mzlogin commented Mar 13, 2019

Hi~首先感谢你的 PR。

是什么情况下出现问题呢?可以详细描述一下吗?

@iluchen
Copy link
Author

iluchen commented Mar 14, 2019

new gitalk 中 id 的值单引号格式错误(单引号中嵌套了单引号),在gitalk 初次加载的时候会报错 Not found 。

@mzlogin
Copy link
Owner

mzlogin commented Mar 25, 2019

不好意思过了好久了才回复你,有没有报错的截图或者能预览到这个错误的例子啊?
我理解你说的意思,但我没复现出问题来……

@iluchen
Copy link
Author

iluchen commented Mar 25, 2019

image
这个。。

@mzlogin
Copy link
Owner

mzlogin commented Mar 25, 2019

你说的代码里的这个地方我知道,我看到你的 commit 了。

你是实际遇到有报错呢,还是只是从语义上理解它有问题?

我理解的话,{{ }} 里的内容在 Jekyll 编译过程中会替换成实际的值,这样页面的 JavaScript 里不会有这样的代码,你遇到的情况是?可以截图或者有在线的例子能让我也看到吗,或者能麻烦你告诉一下如何复现

@iluchen
Copy link
Author

iluchen commented Mar 25, 2019

Jekyll 编译过程中会替换成实际的值,这个的话我倒是没看过。我遇到的问题是,使用gitalk的时候初次加载页面报错 not found ,gitalk加载失败了,然后我看了下这个地方的有语法问题,修改后就加载正常了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants