-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support customized logger for Boomer, Output and runner #194
Conversation
Please make sure the tests are passed. |
@myzhan Could you approve the workflow again? Local tests work now with default loggers added. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #194 +/- ##
==========================================
+ Coverage 80.60% 81.28% +0.67%
==========================================
Files 10 10
Lines 1542 1576 +34
==========================================
+ Hits 1243 1281 +38
+ Misses 248 244 -4
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hmmmm, I have no idea why the windows one failed, but I can add tests for |
I think the windows machine make some time-sensitive testcases flaky, your changes are not related. Yes, you can add testcases for WithLogger. |
@myzhan Hopefully it's green for Codecov this time. |
Let's go ahead and merge it! If it works for you @myzhan :D |
Done, thx. |
The new feature is totally backwards compatible, while it allows user to customize the logger for
Boomer
,Output
andrunner
.Added:
func (b *Boomer) WithLogger(logger *log.Logger) *Boomer
func (o *XxxOutput) WithLogger(logger *log.Logger) *XxxOutput