Add constructor that pass an Annotation type instead of Object on ProviderSqlSource #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viderSqlSource The motivation for this change is to resolve issues that prevent GraalVM support. See mybatisgh-1552
harawata
reviewed
Jul 21, 2019
There was a problem hiding this comment.
Thank you, @kazuki43zoo !
The second parameter should have been declared as Annotation in the first place, I think.
I just added one clarification.
src/main/java/org/apache/ibatis/builder/annotation/ProviderSqlSource.java
Show resolved
Hide resolved
What mean? Is correct a current method declarement? |
|
I meant |
…r of ProviderSqlSource See mybatisgh-1611
harawata
approved these changes
Jul 22, 2019
kazuki43zoo
added
the
polishing
kazuki43zoo
deleted the
add-constructor-with-annotation-on-sqlprovidersource
branch
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
…r of ProviderSqlSource See mybatisgh-1611
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
…-annotation-on-sqlprovidersource Add constructor that pass an Annotation type instead of Object on ProviderSqlSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this change is to resolve issues that prevent GraalVM support. See gh-1552
I want to resolve issues that prevent GraalVM support on step by step.
WDYT?