Wine fix #2854
Open
Wine fix #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround to make sure `wine` fails in packages' build processes was to set `WINEPREFIX` to a read-only directory. However, this fails if this read-only directory is in fact not read-only, as can happe when compiling MXE as `root` in a docker environment. Setting `WINEPREFIX` to `/dev/null` fixes this without the workaround. This closes mxe#2819.
The code casts `ChangeDisplaySettingsEx`'s return type (`LONG`) to `unsigned int` but then compares it to other `LONG`s in a `switch` statement. This becomes an error with GCC 12. We fix it locally.
mabrand
approved these changes
May 23, 2022
|
ping @tonytheodore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the two commits' commit messages for the changes.