[ci] Windows #1239
Open
[ci] Windows #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Swift 5 only * No ObjC * No deprecations * No submodules * Uses SwiftPM to generate an `.xcodeproj`
* Additional comments for Dispatcher.swift * Remove .promise namespacer from Dispatcher.dispatch -> Guarantee/Promise * Convert to LogEvent system, groom logging and tests * Expand DispatchQueueDispatcher to hold both a DispatchGroup and a QoS * Finalize dispatcher.dispatch and related tests * Clean up DispatchQueue wrapping, avoid assuming any particular defaults * CurrentThreadDispatcher.dispatch needn't mark closure arg as @escaping * Test that DispatchQueue.pmkDefault is identifiable with === * Documentation updates * Build any v7* branch * Rebuild Linux test manifest, check return types of Dispatcher.dispatch {}
* Add StrictRateLimitedDispatcher * Add ConcurrencyLimitedDispatcher * StrictRateLimitedDispatcher now schedules only on execution * Refactor rate limited dispatchers onto common base * Limiter dispatchers complete and tested * Add CoreDataDispatcher * Grooming, doc comments, NSLock -> DispatchQueue * Break Dispatcher implementation tests into separate classes to allow parallelism * Move time measurement outside of serialization for rate limit test * Update testing for Linux and slow Travis environments * Build all v7 branches
This patch adds the concept of a `CancelContext` to PromiseKit allowing chains to handle cancellation properly for each independent promise after the cancel point.
Dispatchers cleanup
* Fix "Typechecking timeout compiling tests in v7 #1026" by specifying the closure return type in DispatcherTests * Remove unnecessary "#if swift" checks in the cancellable code and tests
'Cancel' for PromiseKit: fix for #1026, plus cleanup
Rationale: Since this variant takes a specific error object, it does not need checked against in handler and is therefore likely to be explicitly ignored (`_ in`). Thus removing the object removes the need for this.
Because for this error type accepting variant of catchOnly it makes sense to want to not catch specific cancellable cases in the type.
[deps] JS bump, attempting to get rid of audit
[ci] Reject trailing whitespace
[ci] use `concurrency` rather than auto-cancel
[ci] more thorough matrix
[ci] use Swift rather than Xcode versions
mxcl
force-pushed
the
ci/windows
branch
6 times, most recently
from
8194ce7
to
4a2297f
Compare
mxcl
force-pushed
the
master
branch
7 times, most recently
from
35125e0
to
37607f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.