Update implementation to use non-deprecated api calls #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combines the two open PRs so the tests pass and we don't depend on outdated gRPC internals.
- put codec in subpackage - use encoding.Codec - add comments
- use non-deprecated calls
- use non-deprecated api calls - change `break` statement to `continue` in main handler loop - update tests - make tests actually use the testing logger
- implement Register() func - change receiver names and types
- include updated examples - fix typo
|
Will this be merged anytime soon? |
|
I'm also waiting for this to be merged |
|
Will it ever be merged? Is this repo to maintained anymore @mwitkow ? If you no longer want to maintain can you transfer to someone that does or give someone rights to merge PRs? |
| @@ -88,13 +90,13 @@ func (s *handler) handler(srv interface{}, serverStream grpc.ServerStream) error | |||
| // this is the happy case where the sender has encountered io.EOF, and won't be sending anymore./ | |||
| // the clientStream>serverStream may continue pumping though. | |||
| clientStream.CloseSend() | |||
| break | |||
| continue | |||
There was a problem hiding this comment.
Probably not in this context. I ran staticcheck and fixed check SA4011 here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the implementation to use the newer
grpc/encodingpackage.To use
grpc/encodingCodec interface the proxy has to register the codec asproto. Otherwise the marshalling/unmarshalling will fail. The proxy codec has to completely overwrite theprotocodec behavior. I extended the codec test to make sure regularprotomessage get marshaled/unmarshalled correctly.