Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard: final touches #3

Merged
merged 2 commits into from
May 17, 2023
Merged

Leaderboard: final touches #3

merged 2 commits into from
May 17, 2023

Conversation

musangamfure
Copy link
Owner

@musangamfure musangamfure commented May 17, 2023

Hello,

In this PR, I styled the leaderboard project by applying medium-fidelity wireframes to create a UI.

These are what I have achieved:

Learderboard
  • Improved the look and feel of the application, adding the styles of my choice.
  • Kept the general layout of the wireframe
  • Use plain CSS in styling

Kindly check, and let me know what you think.

Best Regards.

Emmanuel.

@musangamfure musangamfure temporarily deployed to github-pages May 17, 2023 14:37 — with GitHub Pages Inactive
Copy link

@Strangeal Strangeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @musangamfure,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Alt Text

Highlights

Correct use of GitHub Flow ✅
Well-structured files ✅
All linter checks are passing ✅
Descriptive PR title with a great summary ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@musangamfure
Copy link
Owner Author

Hello @Strangeal,

Thank you 🙌 for your Insightful and encouraging review.

@musangamfure musangamfure merged commit 90e4565 into development May 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants