Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard: hit the API #2

Merged
merged 5 commits into from
May 17, 2023
Merged

Leaderboard: hit the API #2

merged 5 commits into from
May 17, 2023

Conversation

musangamfure
Copy link
Owner

Hello,

In this PR, I have implemented a new feature on Leaderboard Project which is sending and receiving data from/to the Leaderboard API.

These are what I have achieved:

  • Create a new game by using the API.
  • Implement the "Refresh" button that will get all scores for a game created by you from the API (receiving data from the API and parsing the JSON).
  • Implement the form "Submit" button that will save a score for a game
  • Use arrow functions instead of the function keyword.
  • Use async and await JavaScript features to consume the API.
  • Styling the game.

Kindly check my project and let me know what you think

Best regards.

Copy link

@wayungi wayungi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @musangamfure ,

image

Congratulations on the good job done so far! 🤝

There are some issues that you still need to work on to go to the next project but you are almost there! 😄

Highlights ⚡ ⚡

  • Great use of arrow functions 👏🏾
  • Application runs well 👏🏾
  • Amazing styling 🥇

Required Changes ♻️

Check the comments under the review.

  • Please fix your live demo link by using the correct deployment link or deleting the live demo section Iff live deployment is not a project requirement

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link

@AbelG101 AbelG101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @musangamfure 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it.
Congratulations! 🎉 🥳🥇

Highlights

  • Correct use of GitHub Flow ✔
  • Well-structured files ✔
  • All linter checks are passing ✔
  • Descriptive PR title with a great summary ✔

Optional suggestions

  • N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@musangamfure musangamfure merged commit 5dfc2f0 into development May 17, 2023
5 checks passed
@musangamfure musangamfure temporarily deployed to github-pages May 17, 2023 12:51 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants