[RangePicker] Make text separator correctly aligned vertically #15981
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update style of MultiInput...RangeField Root and Seperator
good-jinu
changed the title
|
Deploy preview: https://deploy-preview-15981--material-ui-x.netlify.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15847
Root cause
The root cause of this issue is the misalignment of the three elements. They are currently centered based on the height of the TextField element, which includes the helper text. This is causing the elements to appear misaligned when the helper text is present or has varying lengths.
What is changed
MultiInput...RangeFieldFilesMultiInputDateRangeFieldMultiInputDateTimeRangeFieldMultiInputTimeRangeField: This feature isn't implemented yet. But it needed to be modified as the same issue occursTo minimize additional bugs and PR, I chose the simplest method.
Before
codesandbox
After
codesandbox