[pickers] Update closeOnSelect and actionBar.actions default values
#15944
+182
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
breaking change
component: pickers
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
LukasTy
commented
Dec 20, 2024
| @@ -53,6 +53,7 @@ const DesktopDateRangePicker = React.forwardRef(function DesktopDateRangePicker< | |||
|
|
|||
| const props = { | |||
| ...defaultizedProps, | |||
| closeOnSelect: defaultizedProps.closeOnSelect ?? true, | |||
There was a problem hiding this comment.
Explicitly providing true default in case of DesktopDateRangePicker and DatePicker.
LukasTy
commented
Dec 20, 2024
LukasTy
commented
Dec 20, 2024
LukasTy
commented
Dec 20, 2024
LukasTy
commented
Dec 20, 2024
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
LukasTy
commented
Dec 20, 2024
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Lukas Tyla <[email protected]>
| Only `<DesktopDatePicker />` and `<DesktopDateRangePicker />` have `closeOnSelect` set to `true` by default. | ||
|
|
||
| This change goes hand in hand with the new default `actions` prop value for the `<PickersActionBar />` component. | ||
| The default value of the `actions` prop has been updated to `['cancel', 'accept']` for all Picker components with complex views, except for `<DesktopDatePicker />` and `<DesktopDateRangePicker />`. |
There was a problem hiding this comment.
I would remove the concept of "complex" value which is very subjectif and instead list the pickers.
| This change goes hand in hand with the new default `actions` prop value for the `<PickersActionBar />` component. | ||
| The default value of the `actions` prop has been updated to `['cancel', 'accept']` for all Picker components with complex views, except for `<DesktopDatePicker />` and `<DesktopDateRangePicker />`. | ||
|
|
||
| If the updated values do not fit your use case, you can override them. |
There was a problem hiding this comment.
A link on the doc that shows how to override can be a nice addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created from #14397.
Closes #9310.