[DataGrid] Show label on the filter tooltip #15933
Open
+122
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5492
How it currently works
Here's the example code
When mouse goes over Filter button, It shows the tooltip
The tooltip shows the value (Status 0,Status 1), while people most likely expecting to see the label (pending,success).
Since It shows the label for other spaces, It makes sense to show label rather than the value.
How It changed
I've modified the getValueAsString function to use label instead of value for the singleSelect type
When valueOptions is given with label, The tooltip shows the label.
Given the function name getValueAsString, I'm not entirely sure if passing label is the best approach.