[DataGrid] Refactor: create base button props #15930
Open
+57
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
the
component: data grid
|
Deploy preview: https://deploy-preview-15930--material-ui-x.netlify.app/ |
KenanYusuf
approved these changes
Dec 19, 2024
|
|
||
| export type IconButtonProps = Omit<ButtonProps, 'startIcon'> & { | ||
| color?: 'default' | 'primary'; | ||
| edge?: 'start' | 'end' | false; |
There was a problem hiding this comment.
There are quite a few props for buttons that don't make sense in a non-Material UI world, including this, but I think we can fine tune these later.
There was a problem hiding this comment.
You mean edge? Yeah I guess so, though if we remove it I'm sure it's going to cause a visual regression somewhere. I'm still wondering how we're going to add those little tunings while being design-system agnostic.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the design-agnostic work.
Setup button props to replace material button props.