Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Strengthen default desktopModelMediaQuery prop value to avoid false positives #15926

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Dec 18, 2024

Strengthen the desktopModelMediaQuery default value to avoid false positives when mobile devices might report as capable of a precise pointer, but not hover.

Part of #10039.

Revival of #10064.

This is the only relevant change: https://github.com/mui/mui-x/pull/15926/files#diff-ad2eb94cb4c75196d92810b38d94a7d91ea62f51d32e49a8b3321734b2627153R61

@LukasTy LukasTy added the component: pickers This is the name of the generic UI component, not the React module! label Dec 18, 2024
@LukasTy LukasTy self-assigned this Dec 18, 2024
@mui-bot
Copy link

mui-bot commented Dec 18, 2024

Deploy preview: https://deploy-preview-15926--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against fa0e551

@LukasTy LukasTy changed the title Pickers desktop mode media query [pickers] Strengthen default desktopModelMediaQuery prop value to avoid false positives Dec 18, 2024
@LukasTy LukasTy added the enhancement This is not a bug, nor a new feature label Dec 18, 2024
@LukasTy LukasTy marked this pull request as ready for review December 18, 2024 13:42
@LukasTy LukasTy requested a review from a team December 18, 2024 13:42
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants