Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Force /base-ui redirect #45083

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Jan 22, 2025

Deleted the corresponding page to make the redirect work, also added a redirect in the Next.js config (for client side routing)

@mj12albert mj12albert added the docs Improvements or additions to the documentation label Jan 22, 2025
@mj12albert
Copy link
Member Author

https://deploy-preview-45083--material-ui.netlify.app/base-ui/
Even with the trailing slash it isn't working 🤔

@mj12albert
Copy link
Member Author

The redirect appears to be correct in the netlify deploy log: https://app.netlify.com/sites/material-ui/deploys/67909b10db98830008a44b56#L1449

@mj12albert
Copy link
Member Author

mj12albert commented Jan 22, 2025

Turns out ! is needed as in /base-ui https://base-ui.com 301! because the corresponding page/file for /base-ui isn't deleted

https://docs.netlify.com/routing/redirects/rewrites-proxies/#shadowing

@mj12albert mj12albert changed the title [docs] Add trailing slash to base-ui redirect [docs] Force /base-ui redirect Jan 22, 2025
@mj12albert mj12albert marked this pull request as ready for review January 22, 2025 10:05
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @alexfauquette suggested somewhere else, I think it's better to remove the page instead of using !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants