[material-ui][Popover] Deprecate *Props and complete slots, slotProps
#45035
+462
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
component: Popover
Netlify deploy previewPopover: parsed: +0.72% , gzip: +0.45% Bundle size reportDetails of bundle changes (Toolpad) |
sai6855
reviewed
Jan 16, 2025
| @@ -63,6 +63,12 @@ describe('<Popover />', () => { | |||
| <ReplacementPaper ref={ref} {...props} data-testid="custom" /> | |||
| )), | |||
| }, | |||
| backdrop: { | |||
There was a problem hiding this comment.
Suggested change
| backdrop: { | |
| transition: { | |
| expectedClassName: classes.transition, | |
| testWithElement: null, | |
| }, |
i think test for transition slot is missing
36 tasks
DiegoAndai
reviewed
Jan 21, 2025
| @@ -644,7 +644,7 @@ function testSlotPropsCallbackWithPropsAsOwnerState( | |||
| const { queryByTestId } = await render( | |||
| React.cloneElement(element, { slotProps, className: 'custom' }), | |||
| ); | |||
| const slotComponent = queryByTestId('custom'); | |||
| const slotComponent = queryByTestId('custom', { exact: false }); | |||
There was a problem hiding this comment.
For slots that are passed to inner component like the backdrop, the className from the ownerState is concatenated with the outer component's className, so the value is not exactly custom.
The { exact: false } still capture the custom class but neglect other classes from the outer component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41281
BackdropComponent,BackdropProps,PaperProps,TransitionComponent, andTransitionProps.root,paper,transition, andbackdropslots