[draft] migrate react-docgen to v6 #45028
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45028--material-ui.netlify.app/ Bundle size report |
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the temptative to bump react-docgen.
The version bump has nice benefits:
I did not managed to make the script fully run from start to end. But while working on it, I've seen some concerning issues on their github, like Missing support for Pick<> and Omit<>. And I'm not sure about how active the community is about maintaining the lib.
The alternative could be to use TSDocs
mui/mui-x#15836
Next step
I will do a comparison of what is accessible form
react-docgenandTSDocsto test is they both provide the same content, or if one is "better" than the other