[Field] Add filled and focused style hooks #1341
Conversation
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -79,6 +79,7 @@ export function useRadioRoot(params: useRadioRoot.Parameters) { | |||
| setFieldTouched(true); | |||
| setDirty(value !== validityData.initialValue); | |||
| setCheckedValue(value); | |||
| setFilled(true); | |||
There was a problem hiding this comment.
@atomiks I think in addition to this RadioGroup also needs to setFilled() in an effect or something, otherwise the initial filled state is incorrect: https://codesandbox.io/p/sandbox/inspiring-ishizaka-ykvk9c?file=%2Fsrc%2FApp.tsx%3A37%2C1
There was a problem hiding this comment.
The same happens when using CheckboxGroup in a Field as well 🤔
There was a problem hiding this comment.
Updated - I'm not sure if a data-filled state should be added for the CheckboxGroup node; probably not crucial
There was a problem hiding this comment.
I think it's enough to have it on Field ~
|
The new hooks' descriptions are missing from the docs. |
Closes #1324