[core] Enable stylelint on CSS files #1184
Open
+60
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
oliviertassinari
added
core
Comment on lines
156
to
157
| --color-gray-700: oklch(92% 1.125% 264 / 80%); | ||
| --color-gray-800: oklch(92% 1.125% 264 / 80%); | ||
| --color-gray-800: oklch(93% 0.875% 264 / 85%); |
There was a problem hiding this comment.
Duplicated value, seems wrong
Netlify deploy preview |
Comment on lines
-47
to
-50
| &[data-orientation='vertical'] { | ||
| width: 0.25rem; | ||
| } | ||
|
|
oliviertassinari
changed the title
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we didn't lint the .css files after my IDE reported issues opening them (using https://marketplace.visualstudio.com/items?itemName=stylelint.vscode-stylelint). It seems that we should start to lint those. There are too many rules to fix for me to make sense to do it, but I went with the simplest, quick win path:
I think next we could: