Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Fix support tier-1 flow regression #1149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 17, 2024

I have noticed this from #1148. The support flow seems to have had a couple of problems with #985. This PR aims to go after 1.

  1. https://www.notion.so/mui-org/GitHub-community-issues-PRs-Tier-1-12a84fdf50e44595afc55343dac00fca no longer working, added the status: waiting for maintainer label back in. Similar workflow of the Rust team https://github.com/orgs/community/discussions/139935#discussioncomment-11594872
  2. Bug reports no longer prompt developers to provide the exact version of their dependencies @mui/envinfo. [envinfo] Ask for output from envinfo in issues material-ui#23881
  3. Bug reports and issue reports have a redundant H1, e.g. [accordion] <summary> / <details> based implementation #1148
  4. We no longer have the "Search keywords". Added in [core] Update issue actions & templates mui-x#10375 because it started to be really hard to find duplicate issues
  5. https://discord.com/channels/1287292451308048406/1287292451308048409 link doesn't work. If we link to Discord, I think [docs] Avoid broken link material-ui#38154 will avoid leaving breadcrumbs of broken links.

On using issue templates (now in Base UI, React, Tailwind CSS) vs. issue forms (Next.js, React Aria). I'm biased for issue forms, since mui/mui-x#2468. But happy either way. It feels like once we become tired of developers opening issues without respecting what we ask for, we will naturally land on issue forms.

@oliviertassinari oliviertassinari added the scope: infra Org infrastructure work going on behind the scenes label Dec 17, 2024
@flaviendelangle
Copy link
Member

We no longer have the "Search keywords". Added in mui/mui-x#10375 because it started to be really hard to find duplicate issues

I suspect it has been removed after https://mui-org.slack.com/archives/C02P87NQLJC/p1733997960666959

@mui-bot
Copy link

mui-bot commented Dec 17, 2024

Netlify deploy preview

https://deploy-preview-1149--base-ui.netlify.app/

Generated by 🚫 dangerJS against 5851c67

Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have the labels been removed in the first place? And shouldn't we also add the default labels, like bug, feature to the respective templates as well? 🤔

@@ -1,6 +1,7 @@
---
name: 'Bug report'
about: 'File a bug report.'
labels: ['status: waiting for maintainer']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: ['status: waiting for maintainer']
labels: ['status: waiting for maintainer', 'bug 🐛']

@@ -1,6 +1,7 @@
---
name: 'Feature request'
about: 'Suggest a new component or an enhancement for an existing component.'
labels: ['status: waiting for maintainer']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: ['status: waiting for maintainer']
labels: ['status: waiting for maintainer', 'new feature']

@@ -1,6 +1,7 @@
---
name: 'Get help'
about: 'Ask a question.'
labels: ['status: waiting for maintainer']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: ['status: waiting for maintainer']
labels: ['status: waiting for maintainer', 'support: question']

@@ -1,6 +1,7 @@
---
name: 'Docs feedback'
about: 'Help us improve Base UI documentation.'
labels: ['status: waiting for maintainer']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: ['status: waiting for maintainer']
labels: ['status: waiting for maintainer', 'support: docs-feedback']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants