Feat/#203 support nullable nested objects #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is regarding issue #203
I have extended the existing
ModelValueType
and the functionisModelValueType
to allow forobject
type.I also added a new test case covering the scenario described in #203 .
It was indeed failing at the beginning, the object would be null no matter whether or not you passed to create an existing object.
This was caused by
isModelValueType
that would returnfalse
if the object was not a Primitive or an Array of Primitives.The test is now passing, and I've also tested it manually.
Note that this is my PR for this project and unfortunately the tests were not all green out of the box. So I manually checked where these functions/types were used to ensure I didn't break existing functionalities.
Please don't hesitate to let me know if anything needs to be changed.