input: misc: qcom-spmi-haptics: make auto res mode and vmax configureable via DT prop #217
+66
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think one of your commit prefix is not correct. Check this https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/submitting-patches.rst You should separte schema modifications from the code modification |
…DT prop Signed-off-by: Antony K. S <[email protected]>
also: * remove unused HAP_VMAX_MAX_MV_STRONG * adjust spmi_haptics_play_effect so that it's not overriding the vmax from DT Signed-off-by: Antony K. S <[email protected]>
…he Qualcomm SPMI haptics Signed-off-by: Antony K. S <[email protected]>
Smankusors
force-pushed
the
haptic-auto-res-vmax-dt-prop
branch
from
971559b to
e0741e1
Compare
ok, updated and rebased 👍 |
barni2000
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested on my Zenfone 3 ZE520KL with pmi8952, and it works as I wanted using
qcom,auto-res-mode = <HAP_AUTO_RES_QWD>andqcom,vmax-millivolt = <1500>.On another note, I noticed that the pm660 has only two available auto res modes to select:
https://github.com/Zenfone-5-X00QD-4-19/kernel_asus_sdm660/blob/3163b5f4e036f69e43626ae60f4b67b8bb61b733/drivers/soc/qcom/qpnp-haptic.c#L232-L235
I think supporting the pm660 is outside the scope of this PR, and the haptics on my Zenfone 5 with pm660 seem to be functioning normally anyway.
Wdyt?