Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arm64: dts: qcom: msm8916-samsung-j5-common: Upstreaming #258

Closed
wants to merge 0 commits into from
Closed

arm64: dts: qcom: msm8916-samsung-j5-common: Upstreaming #258

wants to merge 0 commits into from

Conversation

wonderfulShrineMaidenOfParadise
Copy link

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise commented Nov 19, 2022 •
edited
Loading

  • Resort commits
  • Fix the authors
  • Add samsung-j3 to upstream, and include it in msm8916-mainline Drop j3 in upstream
  • Add touchscreen to upstream patches Drop touchscreen in upstream Upstreamed touchscreen partially.
  • Add front flash LED. It works as a normal LED instead of a flash LED at the moment.
  • Add msm8916-samsung-j3-common.dtsi
  • Apply new DT schema

Link:

stephan-gh
stephan-gh reviewed Nov 19, 2022
View reviewed changes
arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi Outdated

led-max-microamp = <300000>;
flash-max-microamp = <1500000>;
flash-max-timeout-us = <1835000>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious mostly, where are these values coming from? Or are they just made up?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainl1ne@20c0f7c#diff-92c2357e6d8e3028d5884f443969796f7d690bd991dc913f8f1fdd23575c14b2R219-R221
They are copied values and I am not sure what they do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @nergzd723 can share where they are coming from. I failed to find them in a obvious way downstream.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe downstream KTD2692_MOVIE_CURRENT4 and KTD2692_FLASH_CURRENT16 would match those values. I don't remember how I converted it to uA, exactly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't really understand it, but I guess I'm fine with it as long as you make sure that it works properly :)

arch/arm64/boot/dts/qcom/Makefile Outdated Show resolved Hide resolved
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from msm8916/6.1-rc5 to msm8916/6.1-rc6 November 21, 2022 10:37
@stephan-gh stephan-gh changed the title arm64: dts: qcom: msm8916-samsung-j5-common: Upstreaming (v6) WIP: arm64: dts: qcom: msm8916-samsung-j5-common: Upstreaming (v6) Nov 26, 2022
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from msm8916/6.1-rc6 to msm8916/6.1-rc7 November 29, 2022 04:09
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from msm8916/6.1-rc7 to msm8916/6.1-rc8 December 5, 2022 15:43
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from msm8916/6.1-rc8 to msm8916/6.1 December 12, 2022 15:54
@ap4ss3rby
Copy link

ap4ss3rby commented Dec 19, 2022 •
edited
Loading

I'm not sure what happened, but testing the modified source from on my SM-J500H (3g variant, codename j5), the touchscreen works, but the modem seems to not work, specifically it doesn't detect my SIM card, but otherwise seems to work fine.

@wonderfulShrineMaidenOfParadise
Copy link
Author

wonderfulShrineMaidenOfParadise commented Dec 19, 2022 •
edited
Loading

@ap4ss3rby I don't see modem regressions for now. Does it always or sometimes happen?

@ap4ss3rby
Copy link

ap4ss3rby commented Dec 19, 2022 •
edited
Loading

Well I was testing with a nanoSIM, and since the phone has a slot loading microSIM I wasn't pushing the sim into the socket completely, so it seems like its mostly my fault for not inserting it fully (or not using a SIM adapter), otherwise it seems to be working fine (including only recognizing that my phone is 3g only)

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from msm8916/6.1 to msm8916/6.2-rc1 December 28, 2022 12:01
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from msm8916/6.2-rc1 to msm8916/6.2-rc2 January 2, 2023 09:20
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from msm8916/6.2-rc2 to msm8916/6.2-rc3 January 10, 2023 15:39
stephan-gh pushed a commit that referenced this pull request Oct 17, 2023
@borkmann
selftests/bpf: Test bpf_mprog query API via libbpf and raw syscall
f9b0879 
Add a new test case which performs double query of the bpf_mprog through
libbpf API, but also via raw bpf(2) syscall. This is testing to gather
first the count and then in a subsequent probe the full information with
the program array without clearing passed structs in between.

  # ./vmtest.sh -- ./test_progs -t tc_opts
  [...]
  ./test_progs -t tc_opts
  [    1.398818] tsc: Refined TSC clocksource calibration: 3407.999 MHz
  [    1.400263] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x311fd336761, max_idle_ns: 440795243819 ns
  [    1.402734] clocksource: Switched to clocksource tsc
  [    1.426639] bpf_testmod: loading out-of-tree module taints kernel.
  [    1.428112] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel
  #252     tc_opts_after:OK
  #253     tc_opts_append:OK
  #254     tc_opts_basic:OK
  #255     tc_opts_before:OK
  #256     tc_opts_chain_classic:OK
  #257     tc_opts_chain_mixed:OK
  #258     tc_opts_delete_empty:OK
  #259     tc_opts_demixed:OK
  #260     tc_opts_detach:OK
  #261     tc_opts_detach_after:OK
  #262     tc_opts_detach_before:OK
  #263     tc_opts_dev_cleanup:OK
  #264     tc_opts_invalid:OK
  #265     tc_opts_max:OK
  #266     tc_opts_mixed:OK
  #267     tc_opts_prepend:OK
  #268     tc_opts_query:OK            <--- (new test)
  #269     tc_opts_replace:OK
  #270     tc_opts_revision:OK
  Summary: 19/0 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Daniel Borkmann <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Martin KaFai Lau <[email protected]>
stephan-gh pushed a commit that referenced this pull request Oct 17, 2023
@borkmann
selftests/bpf: Test query on empty mprog and pass revision into attach
685446b 
Add a new test case to query on an empty bpf_mprog and pass the revision
directly into expected_revision for attachment to assert that this does
succeed.

  ./test_progs -t tc_opts
  [    1.406778] tsc: Refined TSC clocksource calibration: 3407.990 MHz
  [    1.408863] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x311fcaf6eb0, max_idle_ns: 440795321766 ns
  [    1.412419] clocksource: Switched to clocksource tsc
  [    1.428671] bpf_testmod: loading out-of-tree module taints kernel.
  [    1.430260] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel
  #252     tc_opts_after:OK
  #253     tc_opts_append:OK
  #254     tc_opts_basic:OK
  #255     tc_opts_before:OK
  #256     tc_opts_chain_classic:OK
  #257     tc_opts_chain_mixed:OK
  #258     tc_opts_delete_empty:OK
  #259     tc_opts_demixed:OK
  #260     tc_opts_detach:OK
  #261     tc_opts_detach_after:OK
  #262     tc_opts_detach_before:OK
  #263     tc_opts_dev_cleanup:OK
  #264     tc_opts_invalid:OK
  #265     tc_opts_max:OK
  #266     tc_opts_mixed:OK
  #267     tc_opts_prepend:OK
  #268     tc_opts_query:OK
  #269     tc_opts_query_attach:OK     <--- (new test)
  #270     tc_opts_replace:OK
  #271     tc_opts_revision:OK
  Summary: 20/0 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Daniel Borkmann <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Martin KaFai Lau <[email protected]>
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from msm8916/6.6-rc5 to wip/msm8916/6.8 March 15, 2024 02:30
@TravMurav TravMurav force-pushed the wip/msm8916/6.8 branch 2 times, most recently from 8cc957b to 8c4a987 Compare March 26, 2024 09:39
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from wip/msm8916/6.8 to wip/msm8916/6.9 June 1, 2024 09:33
@TravMurav TravMurav force-pushed the wip/msm8916/6.9 branch 2 times, most recently from 98939cb to c4d3662 Compare June 5, 2024 14:09
@TravMurav TravMurav force-pushed the wip/msm8916/6.9 branch 2 times, most recently from e7a0931 to 903e6f0 Compare June 6, 2024 05:09
@wonderfulShrineMaidenOfParadise
Copy link
Author

There are regressions found in KTD2692 driver. b5a8c50 needs to be reverted to get front torch working.

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the base branch from wip/msm8916/6.9 to wip/msm8916/6.10 July 26, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephan-gh stephan-gh stephan-gh left review comments

@nergzd723 nergzd723 nergzd723 left review comments

@LorenDB LorenDB LorenDB left review comments

Assignees
No one assigned
Labels
upstreaming
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wonderfulShrineMaidenOfParadise @ap4ss3rby @stephan-gh @nergzd723 @LorenDB