PNG case sensitive issue #3
Open
+5,888
−5,533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved layout detection - 300 dpi or more at least
- MIN_HVF_WIDTH = 2400
- Improved VFI detection
2 extract more fields
|
Hi Alan, thanks for catching. I forgot how case-sensitively Linux FS can be. Thanks for making the changes!
I’m curious regarding use cases for this program - what are you using the HVF extraction for?
Sincerely,
Murtaza
…On Jul 7, 2022, 5:50 AM -0400, Alan Silva ***@***.***>, wrote:
I use macOS case sensitive FS but, weirdly, it didn't spot the issue. Deploying the script inside docker and then it was not working anymore.
https://github.com/msaifee786/hvf_extraction_script/tree/master/hvf_extraction_script/hvf_data/value_icons/v2
Shows files with png lowercase, but code in https://github.com/msaifee786/hvf_extraction_script/blob/master/hvf_extraction_script/hvf_data/hvf_value.py requires '.PNG' (uppercase).
This is usually not an issue int Mac or Windows but it should be in Linux or any case sensitive FS.
You can view, comment on, or merge this pull request online at:
#3
Commit Summary
• b1ceb9e Fixed wrong lowercase PNG
• b757a9e Updated .gitignore
File Changes
(13 files)
• M .gitignore (2)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_0.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_1.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_2.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_3.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_4.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_5.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_6.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_7.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_8.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_9.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_less_than.PNG (0)
• R hvf_extraction_script/hvf_data/value_icons/v2/value_minus.PNG (0)
Patch Links:
• https://github.com/msaifee786/hvf_extraction_script/pull/3.patch
• https://github.com/msaifee786/hvf_extraction_script/pull/3.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
We are planning to use mostly for layout type 3 at the Moorfield Eye Hospital. |
* Fixed grid, using aws rekognition * Fine tuning * No tesserOCR any more * VFI * cases * Optional TesserOCR and Rekognition * Linted * Isolate tesserocr * Optional tesserOCR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use macOS case sensitive FS but, weirdly, it didn't spot the issue. Deploying the script inside docker and then it was not working anymore.
https://github.com/msaifee786/hvf_extraction_script/tree/master/hvf_extraction_script/hvf_data/value_icons/v2
Shows files with
pnglowercase, but code in https://github.com/msaifee786/hvf_extraction_script/blob/master/hvf_extraction_script/hvf_data/hvf_value.py requires'.PNG'(uppercase).This is usually not an issue int Mac or Windows but it should be in Linux or any case sensitive FS.