Avoid unnecessary line break at end of files; EOL type detection #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the original file hasn't got a line break at the end, we shouldn't insert one, either. And additionally along with the fix above, we should detect if the original file uses CRLF or LF. CR is not supported. Closes ms-jpq#48.
|
thanks but i cant merge this until i pull out async-std and replace the channels with their separate package, or else it wont compile anyways 😔 been focusing on other projects recently so this might take a few says |
|
@ms-jpq Sure if you have other projects to work on atm, just merge this one when you've got time to clear out the blockers. I can easily patch this locally :) |
|
ok i solved all the dependency issues, this one is next |
|
I fix it |
|
One more issue is maybe rust doesnt split '\r' on '\n', but I gotta do stuff so I guess thats for tomorrow |
ms-jpq
force-pushed
the
senpai
branch
11 times, most recently
from
65878fd
to
eea47a0
Compare
ms-jpq
force-pushed
the
senpai
branch
2 times, most recently
from
e6b4f86
to
19a3cd5
Compare
ms-jpq
force-pushed
the
senpai
branch
2 times, most recently
from
ec5d9af
to
1389b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the original file hasn't got a line break at the end, we shouldn't
insert one, either.
And additionally along with the fix above, we should detect if the
original file uses CRLF or LF. CR is not supported.
Closes #48.