Add support for Firefox

Fixes mitmproxy#5247

mitmproxy/addons/browser.py

@@ -50,12 +50,24 @@ def get_chrome_flatpak() -> Optional[str]:
  return None
 
 
+def get_firefox_executable() -> Optional[str]:
+ for browser in (
+ "/Applications/Firefox.app/Contents/MacOS/Firefox",
+ r"C:\Program Files\Mozilla Firefox\firefox.exe",
+ "firefox",
+ ):
+ if shutil.which(browser):
+ return browser
+
+ return None
+
 def get_browser_cmd() -> Optional[list[str]]:
  if browser := get_chrome_executable():
  return [browser]
  elif browser := get_chrome_flatpak():
  return ["flatpak", "run", "-p", browser]
-
+ elif browser := get_firefox():
+ return [browser]
  return None
 
 

test/mitmproxy/addons/test_browser.py

@@ -66,3 +66,11 @@ async def test_get_browser_cmd_no_flatpak():
  which.side_effect = lambda cmd: cmd == "flatpak"
  subprocess_run.return_value = mock.Mock(returncode=1)
  assert browser.get_browser_cmd() is None
+
+
+async def test_get_browser_cmd_firefox():
+ with mock.patch("shutil.which") as which:
+ which.side_effect = lambda cmd: cmd == "firefox"
+ assert browser.get_browser_cmd() == ["firefox"]
+
+