Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powershell on Windows support #84

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

kmatt
Copy link

@kmatt kmatt commented Jul 11, 2024

Building on work in #14:

  • Update Git wrapper script
  • Powershell status commands script
  • Documentation update

@mroth
Copy link
Owner

mroth commented Jul 16, 2024

Sorry for the delay in response I was OOO at a conference. This looks great! 🎉 Really appreciate the work here. ❤️ Do you have thoughts on how we can integrate the Powershell testing into the CI? (I also don't have a Windows machine to verify manually.)

@kmatt
Copy link
Author

kmatt commented Jul 16, 2024

@mroth Not sure on CI based tests yet. So far I have only run go test as in the Rakefile. On Windows 11:

> go test ./...
?       github.com/mroth/scmpuff        [no test files]
?       github.com/mroth/scmpuff/commands/exec  [no test files]
?       github.com/mroth/scmpuff/commands/intro [no test files]
ok      github.com/mroth/scmpuff/commands/expand        0.078s
ok      github.com/mroth/scmpuff/commands/inits 0.078s
ok      github.com/mroth/scmpuff/commands/internal/arguments    0.066s
ok      github.com/mroth/scmpuff/commands/status        0.071s

@mroth
Copy link
Owner

mroth commented Jul 20, 2024

I approved the PR running in CI, so you should be able to see the output there as well for integration tests now.

The integration tests are (unfortunately? fortunately?) currently all still implemented in Aruba with Ruby. You can see 867661a as an example of what it looked like to add another shell to the test grid (this was also the PR that added multi-shell support to integration tests).

A few changes there should be enough to get it to work locally -- I suspect there might then have to be some other changes in the GitHub Actions scripts to only run PS tests on Windows runners, etc, but that part should hopefully be straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants