Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): add shellcheck linting #57

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

build(ci): add shellcheck linting #57

wants to merge 4 commits into from

Commits on Jan 30, 2022

  1. build(ci): add shellcheck lint

    @mroth
    mroth committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    5fb9626 View commit details
    Browse the repository at this point in the history

  2. build(ci): add shellcheck shell hints

    @mroth
    mroth committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    d82e6ef View commit details
    Browse the repository at this point in the history

  3. fix(init): address shellcheck recommendations

    @mroth
    mroth committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    fc3fcdc View commit details
    Browse the repository at this point in the history

  4. fix(init): remove local from POSIX scripts 

    fixes shellcheck SC3043:
https://github.com/koalaman/shellcheck/wiki/SC3043

strictly speaking, local is not POSIX, but is supported in many shells,
including bash, ksh, dash, and BusyBox ash.

We could disable this rule, but perhaps safer to just do the effort
to try to be fully POSIX compliant for now, even though it makes
the script more difficult to read and reason about.
    @mroth
    mroth committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    46529d6 View commit details
    Browse the repository at this point in the history