osdep/dirent: add implementation for Windows SDK build and other minor changes

[kasper93]

No description provided.

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-i686-w64-mingw32
• mpv-x86_64-w64-mingw32

macOS

• mpv-macos-14-arm
• mpv-macos-13-intel
• mpv-macos-12-intel

[sfan5]

What is "Windows SDK build" referring to here? UWP?

[kasper93]

What is "Windows SDK build" referring to here? UWP?

I'm targeting clang x86_64-pc-windows-msvc, basically native Windows build without mingw dependency and using Windows SDK headers instead. There will be more changes, but first batch, can be reviewed.

[sfan5]

I'm targeting clang x86_64-pc-windows-msvc

Last time someone tried to make some syntax changes (IIRC it was something about varargs macros) to fix the build on MSVC wm4 thought it was stupid and rejected the PR. This was years ago, of course.
clang-cl might be okay since that's a more modern compiler but I tend to agree that having to avoid <unistd.h> in what is otherwise portable code is a bit annoying.

Edit: I mistook clang-cl for what this PR actually does.

[kasper93]

MSVC wm4 thought it was stupid and rejected the PR.

Supporting cl or clang-cl would be insanely stupid, there would be very awkward changes/workarounds to support it. But nowadays clang with GNU driver fully supports Windows and there is no reason to not provide such build. I have some more changes, but none of them are really painful. Else I wouldn't push forward with it. Except maybe dirent thing itself, but it is only one big change that has to be included.

I tend to agree that having to avoid <unistd.h> in what is otherwise portable code is a bit annoying.

I see, but in practice if it is in common.h it shouldn't be a problem. Minor inconvenience at best imo.

EDIT:

Just to give a context mpv is a bad egg that do not actually support building with Windows SDK. libass, ffmpeg, libplacebo all support it. lua, mujs and others too, but for now I'm working on bare bones build. lua has meson wraps for >=5.3 and we are supporting up to 5.2, but this is a topic for future me.

[ruihe774]

lua has meson wraps for >=5.3 and we are supporting up to 5.2, but this is a topic for future me.

LuaJIT and other dependencies are in vcpkg. Giving meson can read cmake packages, the easier way is to build mpv with vcpkg packages, I think.

[kasper93]

Thank you for suggestion, but it is not in the scope for now. I will do it, when the time comes.

[kasper93]

Not sure what you want to say, but works for me.

[kasper93]

I don't need it, thank you.

[kasper93]

Updated with the rest of the changes and ci build. This PR is finished. I have some changes to add lua, spirv-cross, shaderc, but his is for next PR.

[kasper93]

I will merge tomorrow if there are no objections. I think the changes are not that scary.

[kasper93]

Changed libmpv build to shared and added to artifacts. Might be useful to some.

EDIT: Not really, because it currently is awkward to build shared library with all subprojects build as static one. So to make it not bloated, leave as is. Meson changes for this are discussed here mesonbuild/meson#13086 (comment) I will revisit idea of shipping libmpv.so once those are merged.