fix silence trimming for flac files #369
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FLAC plugin doesn't process the last frames while using the trim silence option, which means it only ever detects one splitpoint (and thus fails to write anything). I copied this code snippet over from the mp3 plugin to fix this. No idea if this breaks anything else, but in the specific case of trimming silence from FLAC files, it seems to work.
Headers for the file are probably gonna be messed up, though -- I'd recommend a round of
ffmpeg -i <filename>.flac -c:a flac <filename>_reencode.flac
afterwards. But the audio data seems intact!