Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #74: replaces read_uint_le with utility function #325

Draft
wants to merge 3 commits into
base: ctap2-2021
Choose a base branch
from

Conversation

ndarrell
Copy link

@ndarrell ndarrell commented Dec 7, 2023

resolves #74

Hello! Learning rust, so please excuse me for being misinformed in any way 😄. Any comments or feedback on this would be greatly appreciated!

I had trouble building this off of the default ctap2-2021 branch (did

$ cargo build --example main
# also tried
$ cargo test
``` as the README states, but neither worked), so I tried running the same fix off of `main` where there's similar code. I got a completed run of `cargo test`, but I was not able to get a reproducible failure when just commenting out the old function. I feel I may have missed something with my testing, so, again, any sort of help would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use byteorder::ReadBytesExt instead of a local implementation
1 participant