Detect if no devices are connected and send a StatusUpdate accordingly. #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msirringhaus
force-pushed
the
send_plugin_device_notice
branch
from
512ee9e
to
26aa766
Compare
|
Unfortunately I don't think we can accept this until we have a solution for macOS (Firefox is going to stick with auth-rs for security keys on macOS for the foreseeable future). Should I try to find someone who can help us debug the macOS issue? |
Sorry, it totally missed the question in there, and read it as a statement. Yes, it would be great if you could find somebody who knows the macOS SDK and how things work there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #312
This is not working for macOS, as I have no idea how to get the already plugged in devices (and if none are plugged in, an empty list) on that platform.
Upon start, we make the
MonitorsendDevicesAddedwith an empty list, to let theDeviceSelectorknow we are starting and have no device yet. Then whenever devices are removed (either by sendingNotATokenor being physically plugged out), we check if it was the last one. If so, we send theStatusUpdateaccordingly.