Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CTAP2 canonical CBOR encoding for PublicKeyCredentialDescriptor #235

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Use CTAP2 canonical CBOR encoding for PublicKeyCredentialDescriptor #235

merged 1 commit into from
Mar 20, 2023

Conversation

jschanck
Copy link
Collaborator

@jschanck jschanck commented Mar 20, 2023 •
edited
Loading

Resolves Bug 1823331.

See also #225.

@jschanck jschanck requested a review from mozkeeler March 20, 2023 16:57
mozkeeler
mozkeeler requested changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@mozkeeler mozkeeler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the changes to the ordering of the negative integers are correct.

src/crypto/mod.rs Outdated Show resolved Hide resolved
@jschanck jschanck changed the title Reorder several maps according to CTAP2 canonical CBOR encoding Use CTAP2 canonical CBOR encoding for PublicKeyCredentialDescriptor Mar 20, 2023
mozkeeler
mozkeeler approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jschanck jschanck merged commit 70cd053 into mozilla:ctap2-2021 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozkeeler mozkeeler mozkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschanck @mozkeeler