Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use byteorder::ReadBytesExt instead of a local implementation #74

Open
jcjones opened this issue Dec 14, 2018 · 0 comments · May be fixed by #325
Open

Use byteorder::ReadBytesExt instead of a local implementation #74

jcjones opened this issue Dec 14, 2018 · 0 comments · May be fixed by #325
Labels
enhancement help wanted

Comments

@jcjones
Copy link
Contributor

jcjones commented Dec 14, 2018

read_uint_le is very similar to byteorder::ReadBytesExt, as @mozkeeler pointed out:

https://github.com/jcjones/u2f-hid-rs/blob/26a203290fbb5c912fc109b97f7ba2634725f2cd/src/hidproto.rs#L137-L143

We should try switching to byteorder::ReadBytesExt (and adding it as a dependency).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #74: replaces read_uint_le with utility function ndarrell/authenticator-rs
1 participant
@jcjones