Adding tests (and some minor fixes the tests revealed)

mozilla · Jul 30, 2024 · 77572e2 · 77572e2
1 parent 06785ff
commit 77572e2
Show file tree

Hide file tree

Showing 7 changed files with 449 additions and 10 deletions.
diff --git a/examples/ctap2_discoverable_creds.rs b/examples/ctap2_discoverable_creds.rs
@@ -269,7 +269,7 @@ fn extract_associated_large_blobs(key: Vec<u8>, array: Vec<LargeBlobArrayElement
             let plaintext = cipher.decrypt(e.nonce.as_slice().into(), payload).ok();
             plaintext
         })
-        .map(|d| flate3::inflate(&d))
+        .map(|d| flate3::inflate(&d)) // TODO: Check resulting length and compare to orig_size
         .map(|d| String::from_utf8_lossy(&d).to_string())
         .collect();
     valid_elements

diff --git a/examples/prf.rs b/examples/prf.rs
@@ -149,6 +149,9 @@ fn main() {
             Ok(StatusUpdate::SelectResultNotice(_, _)) => {
                 panic!("Unexpected select device notice")
             }
+            Ok(StatusUpdate::LargeBlobData(..)) => {
+                panic!("Unexpected large blob data request")
+            }
             Err(RecvError) => {
                 println!("STATUS: end");
                 return;

diff --git a/src/ctap2/commands/get_assertion.rs b/src/ctap2/commands/get_assertion.rs
@@ -1100,6 +1100,7 @@ pub mod test {
                     ),
                 )),
                 cred_blob: None,
+                large_blob_key: None,
             },
             options: GetAssertionOptions {
                 user_presence: Some(true),
@@ -1158,6 +1159,7 @@ pub mod test {
                     ),
                 )),
                 cred_blob: None,
+                large_blob_key: None,
             },
             options: GetAssertionOptions {
                 user_presence: None,
@@ -1204,6 +1206,7 @@ pub mod test {
                     },
                 )),
                 cred_blob: None,
+                large_blob_key: None,
             },
             options: GetAssertionOptions {
                 user_presence: None,
@@ -1226,6 +1229,7 @@ pub mod test {
                 app_id: None,
                 hmac_secret: Some(HmacGetSecretOrPrf::PrfUnmatched),
                 cred_blob: None,
+                large_blob_key: None,
             },
             options: GetAssertionOptions {
                 user_presence: None,
@@ -2897,6 +2901,9 @@ pub mod test {
                 },
                 attachment: AuthenticatorAttachment::Unknown,
                 extensions: AuthenticationExtensionsClientOutputs::default(),
+                user_selected: None,
+                large_blob_key: None,
+                large_blob_array: None,
             };
 
             let mut dev = Device::new_skipping_serialization("commands/get_assertion")