bug 1784290: accept dashes in the ID, and compress and serve files named "debuginfo" and "executable" #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following paths in the zip file are now accepted during upload, in
addition to what's accepted today:
- uuid/05E23BCB-EFB0-330B-809B-1EEAC8884B86/executable
- uuid/05E23BCB-EFB0-330B-809B-1EEAC8884B86/debuginfo.dSYM.tar.bz2
TODO: The test still needs to be adapted.
I've added 6 files to the sample.zip:
- The native and sym files for a Linux libfakeopenh264.so (this was the
smallest .so I could find):
- buildid/<hex>/executable
- buildid/<hex>/debuginfo
- libfakeopenh264.so/<hex>/libfakeopenh264.so.sym
- The same for a macOS libfakeopenh264.dylib:
- uuid/<uuid>/executable
- uuid/<uuid>.dSYM.tar.bz2
- libfakeopenh264.dylib/<hex>/libfakeopenh264.dylib.sym
The full contents are now:
```
sample % find . -type f
./build-symbols.txt
./flag/deadbeef/flag.jpeg
./xpcshell.dbg/A7D6F1BB18CD4CB48/xpcshell.sym
./libfakeopenh264.so/E889C906E35FA12037F27850399FC12A0/libfakeopenh264.so.sym
./buildid/06c989e85fe320a137f27850399fc12ad889ddc9/executable
./buildid/06c989e85fe320a137f27850399fc12ad889ddc9/debuginfo
./libnssckbi.so/DFDDFE2B9D3AF892658B766CC9230B320/libnssckbi.so.sym
./uuid/4C862AB7-AB9A-3B6F-9CAB-3FE44CB6FB97/executable
./uuid/4C862AB7-AB9A-3B6F-9CAB-3FE44CB6FB97/debuginfo.dSYM.tar
./libfakeopenh264.dylib/4C862AB7AB9A3B6F9CAB3FE44CB6FB970/libfakeopenh264.dylib.sym
```
These are the filenames used by the debuginfod protocol. In bug 1779439 and bug 1429871 I intend to make the Firefox build system upload files with these names for Linux and macOS native symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes for https://bugzilla.mozilla.org/show_bug.cgi?id=1784290.
At the moment these patches fail tests, and I haven't had a chance to debug those failures.
I'm pushing this branch now in case someone else wants to take a look while I'm on PTO.