New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jsonschema-transpiler's pinned dependencies on install #792

Open

badboy wants to merge 1 commit into mozilla-services:main from badboy:locked-cargo-install

Contributor

badboy commented Oct 31, 2023

See https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile --locked will use the bundled Cargo.lock file with pinned dependencies, instead of recalculating dependency versions. This allows reproducible builds and avoids issues when any dependency releases a new version that contains incompatible changes.

Checklist for reviewer:

Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
If adding a new field, the field should have a description (see Bug 1652842 - Add a blocklist field so the environment schema works with pre- and post-bug-1647225 data #576 for an example)
If coming from a fork, run integration tests: ./.github/push-to-trigger-integration <username>:<branchname>

For glean changes:

Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

Follow the change control procedure


          Use jsonschema-transpiler's pinned dependencies on install

7a2e092

See https://doc.rust-lang.org/cargo/commands/cargo-install.html#dealing-with-the-lockfile
`--locked` will use the bundled Cargo.lock file with pinned
dependencies, instead of recalculating dependency versions.
This allows reproducible builds and avoids issues when any dependency
releases a new version that contains incompatible changes.

auto-assign bot requested a review from akkomar

October 31, 2023 11:29

akkomar approved these changes

View reviewed changes

relud approved these changes

View reviewed changes

Contributor Author

badboy commented Nov 1, 2023

I don't have merge rights here. @akkomar can you land it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet