-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUT-80: Add API endoint to fetch sanitized signer configuration #908
Open
oskirby
wants to merge
16
commits into
main
Choose a base branch
from
aut-80-sanitized-config-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskirby
force-pushed
the
aut-80-sanitized-config-api
branch
from
June 13, 2024 04:06
794e074
to
23dd0b4
Compare
oskirby
force-pushed
the
aut-80-sanitized-config-api
branch
from
June 13, 2024 19:41
7a3d96b
to
b462566
Compare
oskirby
added a commit
to oskirby/autograph
that referenced
this pull request
Jun 13, 2024
oskirby
added a commit
to oskirby/autograph
that referenced
this pull request
Jun 13, 2024
oskirby
force-pushed
the
aut-80-sanitized-config-api
branch
from
June 21, 2024 01:56
b462566
to
a7f1f7d
Compare
oskirby
added a commit
that referenced
this pull request
Jun 21, 2024
oskirby
added a commit
that referenced
this pull request
Jun 21, 2024
oskirby
added a commit
that referenced
this pull request
Jun 21, 2024
oskirby
added a commit
that referenced
this pull request
Jun 22, 2024
oskirby
force-pushed
the
aut-80-sanitized-config-api
branch
from
June 22, 2024 00:49
a7f1f7d
to
882d4bc
Compare
oskirby
added a commit
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to implement the integration test suite with Github Actions in PR #904 I found it rather awkward to replicate the monitor integration tests due our need to pass the root certificate hash around, and this could be made a lot easier if there was a way to fetch public configuration bits from the autograph service, so I wrote an endpoint to do it.
This also aligns nicely with our need for better config discovery and enumeration endpoints, which has been kicking around in JIRA tasks such as: