Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FXIOS-10758 [Sponsored tiles] Create defaultURLSession #23511

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Refactor FXIOS-10758 [Sponsored tiles] Create defaultURLSession #23511

merged 2 commits into from
Dec 3, 2024
+22 −9

Conversation

lmarceau
Copy link
Contributor

@lmarceau lmarceau commented Dec 2, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Found some improvement todo while working to debug the unified ads integration in sponsored tiles.

  • Create a NetworkUtils instead of having some global func
  • Replace http string with proper HTTPMethod, I didn't knew we had this object created

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@lmarceau lmarceau requested a review from a team as a code owner December 2, 2024 18:11
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Dec 2, 2024 •
edited
Loading

Messages
📖 Project coverage: 33.58%
📖 Edited 3 files
📖 Created 0 files

Client.app: Coverage: 31.44

File Coverage
UnifiedAdsCallbackTelemetry.swift 89.13% ✅
UnifiedAdsProvider.swift 85.05% ✅

Generated by 🚫 Danger Swift against 78bf510

issammani
issammani approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Just one question regarding cache.

...os/Client/Frontend/Home/TopSites/DataManagement/UnifiedAds/UnifiedAdsCallbackTelemetry.swift Show resolved Hide resolved
@lmarceau lmarceau merged commit 2eef0a7 into main Dec 3, 2024
10 checks passed
@lmarceau lmarceau deleted the lm/FXIOS-10758-#23478-unified-ads-fix branch December 3, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issammani issammani issammani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmarceau @mobiletest-ci-bot @issammani