Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10678 - [Toolbar Redesign] Add 8dp padding on the right of the URL #23505

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Bugfix FXIOS-10678 - [Toolbar Redesign] Add 8dp padding on the right of the URL #23505

merged 1 commit into from
Dec 3, 2024

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Dec 2, 2024 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Adds 8p of trailing padding for urlTextField.
  • Adjusts the calculation of the location view visible width.

Screenshot

padding

📝 Checklist
You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner December 2, 2024 12:42
@PARAIPAN9
Copy link
Collaborator Author

Tagging @Piratesarereal for UX review.

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.94%
📖 Edited 2 files
📖 Created 0 files

ToolbarKit: Coverage: 25.24

File Coverage
LocationView.swift 22.09% ⚠️
BrowserAddressToolbar.swift 50.91% ✅

Generated by 🚫 Danger Swift against 1752328

@Piratesarereal
Copy link

Yup, looks good.

MattLichtenstein
MattLichtenstein approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@MattLichtenstein MattLichtenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PARAIPAN9 PARAIPAN9 merged commit d7cf964 into main Dec 3, 2024
13 checks passed
@PARAIPAN9 PARAIPAN9 deleted the sparaipan/fxios-10768-Add-8dp-padding-on-the-right-of-the-URL branch December 3, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattLichtenstein MattLichtenstein MattLichtenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PARAIPAN9 @mobiletest-ci-bot @Piratesarereal @MattLichtenstein