Bugfix FXIOS-10756 App hangs while opening Tab Tray when there are many tabs open #23474
+32
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 29, 2024 09:58
…ix Swipe to close tab cell causing a blink when the animation is about to close
Client.app: Coverage: 31.91
Generated by 🚫 Danger Swift against 4752f98 |
|
This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏 |
|
@mergify backport release/v134 |
🟠 Waiting for conditions to match
|
lmarceau
reviewed
Dec 2, 2024
| @@ -291,15 +291,19 @@ class TabTrayViewController: UIViewController, | |||
| } | |||
|
|
|||
| func newState(state: TabTrayState) { | |||
| tabTrayState = state | |||
| updateTabCountImage(count: state.normalTabsCount) | |||
| defer { | |||
There was a problem hiding this comment.
Why do we need to defer the state?
lmarceau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Bug fix App hang while opening the tab tray that is mainly caused by the
TabTrayDisplayView.newStatebeing called many times. OptimizescrollToTabmethod to wait for the collection view layout to finish, instead of forcing layout.Bug fix swipe gesture to delete tab flashing back to normal position after the tab was dismissed.
Here is the link of the currently tracked app hangs Spreadsheet
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)