Add FXIOS-21837 [Onboarding] Add advance card to open iOS FX settings…

… action in main onboarding flow (backport #22428) (#22432) Add FXIOS-21837 [Onboarding] Add advance card to open iOS FX settings action in main onboarding flow (#22428) (cherry picked from commit 8b5882d) Co-authored-by: L. Meg Viar <[email protected]>
mozilla-mobile · Oct 7, 2024 · b7dca22 · b7dca22 · firefoxci-taskcluster · Oct 8, 2024
1 parent 6c378ae
commit b7dca22
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/firefox-ios/Client/Frontend/Onboarding/Views/IntroViewController.swift b/firefox-ios/Client/Frontend/Onboarding/Views/IntroViewController.swift
@@ -338,6 +338,9 @@ extension IntroViewController: OnboardingCardDelegate {
                 selector: #selector(dismissPrivacyPolicyViewController))
         case .openIosFxSettings:
             DefaultApplicationHelper().openSettings()
+            advance(numberOfPages: 1, from: cardName) {
+                self.showNextPageCompletionForLastCard()
+            }
         case .endOnboarding:
             closeOnboarding()
         }

diff --git a/...irefox-ios-tests/Tests/ClientTests/OnboardingTests/Mocks/MockOnboardingCardDelegate.swift b/...irefox-ios-tests/Tests/ClientTests/OnboardingTests/Mocks/MockOnboardingCardDelegate.swift
@@ -59,6 +59,7 @@ class MockOnboardinCardDelegateController: UIViewController,
                                  completion: {})
         case .openIosFxSettings:
             DefaultApplicationHelper().openSettings()
+            showNextPage(numberOfCards: 1, from: cardName, completionIfLastCard: {})
         case .endOnboarding:
             self.action = .endOnboarding
         }

diff --git a/firefox-ios/nimbus-features/onboardingFrameworkFeature.yaml b/firefox-ios/nimbus-features/onboardingFrameworkFeature.yaml
@@ -425,7 +425,7 @@ enums:
           Will request to allow notifications from the user
       set-default-browser:
         description: >
-          Will send the user to settings to set Firefox as their default browser
+          Will send the user to settings to set Firefox as their default browser and advance to next card
       open-instructions-popup:
         description: >
           Will open up a popup with instructions for something